From cd21f70597368f50367c6bc7233a12c0ac5423fc Mon Sep 17 00:00:00 2001
From: Masamune3210 <1053504+Masamune3210@users.noreply.github.com>
Date: Sat, 16 May 2026 19:41:48 -0500
Subject: [PATCH] video_core: trigger P3D on finalize writes

Treat non-zero GPUREG_FINALIZE writes as P3D interrupt requests instead of requiring a byte match against irq_compare. This matches observed homebrew/commercial behavior where 0x12345678 finalizes command buffers and prevents apps from spinning while waiting for P3D completion.
---
 src/video_core/pica/pica_core.cpp | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/src/video_core/pica/pica_core.cpp b/src/video_core/pica/pica_core.cpp
index d264c35b5..91e06252d 100644
--- a/src/video_core/pica/pica_core.cpp
+++ b/src/video_core/pica/pica_core.cpp
@@ -134,11 +134,6 @@ void PicaCore::ProcessCmdList(PAddr list, u32 size, bool ignore_list) {
     }
 }
 
-static bool any_byte_match(u32 a, u32 b) {
-    return ((a & 0xFF) == (b & 0xFF)) || (((a >> 8) & 0xFF) == ((b >> 8) & 0xFF)) ||
-           (((a >> 16) & 0xFF) == ((b >> 16) & 0xFF)) || (((a >> 24) & 0xFF) == ((b >> 24) & 0xFF));
-}
-
 void PicaCore::WriteInternalReg(u32 id, u32 value, u32 mask, bool& stop_requested) {
     if (id >= RegsInternal::NUM_REGS) {
         LOG_ERROR(
@@ -173,9 +168,7 @@ void PicaCore::WriteInternalReg(u32 id, u32 value, u32 mask, bool& stop_requeste
     switch (id) {
     // Trigger IRQ
     case PICA_REG_INDEX(irq_request):
-        // TODO(PabloMK7): This logic is not fully accurate, but close enough:
-        // https://problemkaputt.de/gbatek-3ds-gpu-internal-registers-finalize-interrupt-registers.htm
-        if (any_byte_match(regs.internal.reg_array[id], regs.internal.irq_compare)) [[likely]] {
+        if (regs.internal.reg_array[id] != 0) [[likely]] {
             signal_interrupt(Service::GSP::InterruptId::P3D,
                              delay_generator.CalculateAndResetDelay());
             if (regs.internal.irq_autostop) [[likely]] {