[audio_core, hle, video_core] force inline of functions that only contain thread loops (#3970)

traditionally, when doing jthread:

```
jthread() calls function parameter operator()() with args
function operator()() calls the code within
code within is, say { ThreadMain(); }
3 calls because why not
```

now this just makes it be 2 calls, mainly benefits non-LTO builds

Signed-off-by: lizzie <lizzie@eden-emu.dev>

Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/3970
Reviewed-by: crueter <crueter@eden-emu.dev>
Reviewed-by: MaranBr <maranbr@eden-emu.dev>

src/audio_core/adsp/apps/audio_renderer/audio_renderer.cpp

@@ -29,8 +29,96 @@ void AudioRenderer::Start() {
     CreateSinkStreams();
 
     mailbox.Initialize(AppMailboxId::AudioRenderer);
+    // Main AudioRenderer thread, responsible for processing the command lists.
+    main_thread = std::jthread([this](std::stop_token stop_token) {
+        Common::SetCurrentThreadName("DSP_AudioRenderer_Main");
+        Common::SetCurrentThreadPriority(Common::ThreadPriority::High);
 
-    main_thread = std::jthread([this](std::stop_token stop_token) { Main(stop_token); });
+        // TODO: Create buffer map/unmap thread + mailbox
+        // TODO: Create gMix devices, initialize them here
+
+        if (mailbox.Receive(Direction::DSP) != Message::InitializeOK) {
+            LOG_ERROR(Service_Audio, "ADSP Audio Renderer -- Failed to receive initialize message from host!");
+            return;
+        }
+
+        mailbox.Send(Direction::Host, Message::InitializeOK);
+
+        // 0.12 seconds (2,304,000 / 19,200,000)
+        constexpr u64 max_process_time{2'304'000ULL};
+        while (!stop_token.stop_requested()) {
+            auto msg{mailbox.Receive(Direction::DSP)};
+            switch (msg) {
+            case Message::Shutdown:
+                mailbox.Send(Direction::Host, Message::Shutdown);
+                return;
+
+            case Message::Render: {
+                if (system.IsShuttingDown()) {
+                    std::this_thread::sleep_for(std::chrono::milliseconds(200));
+                    mailbox.Send(Direction::Host, Message::RenderResponse);
+                    continue;
+                }
+                std::array<bool, MaxRendererSessions> buffers_reset{};
+                std::array<u64, MaxRendererSessions> render_times_taken{};
+                const auto start_time{system.CoreTiming().GetGlobalTimeUs().count()};
+
+                for (u32 index = 0; index < MaxRendererSessions; index++) {
+                    auto& command_buffer{command_buffers[index]};
+                    auto& command_list_processor{command_list_processors[index]};
+
+                    // Check this buffer is valid, as it may not be used.
+                    if (command_buffer.buffer != 0) {
+                        // If there are no remaining commands (from the previous list),
+                        // this is a new command list, initialize it.
+                        if (command_buffer.remaining_command_count == 0) {
+                            command_list_processor.Initialize(system, *command_buffer.process,
+                                command_buffer.buffer,
+                                command_buffer.size, streams[index]);
+                        }
+
+                        if (command_buffer.reset_buffer && !buffers_reset[index]) {
+                            streams[index]->ClearQueue();
+                            buffers_reset[index] = true;
+                        }
+
+                        u64 max_time{max_process_time};
+                        if (index == 1 && command_buffer.applet_resource_user_id ==
+                                            command_buffers[0].applet_resource_user_id) {
+                            max_time = max_process_time - render_times_taken[0];
+                            if (render_times_taken[0] > max_process_time) {
+                                max_time = 0;
+                            }
+                        }
+
+                        max_time = (std::min)(command_buffer.time_limit, max_time);
+                        command_list_processor.SetProcessTimeMax(max_time);
+
+                        if (index == 0) {
+                            streams[index]->WaitFreeSpace(stop_token);
+                        }
+
+                        // Process the command list
+                        {
+                            render_times_taken[index] =
+                                command_list_processor.Process(index) - start_time;
+                        }
+
+                        const auto end_time{system.CoreTiming().GetGlobalTimeUs().count()};
+
+                        command_buffer.remaining_command_count =
+                            command_list_processor.GetRemainingCommandCount();
+                        command_buffer.render_time_taken_us = end_time - start_time;
+                    }
+                }
+                mailbox.Send(Direction::Host, Message::RenderResponse);
+            } break;
+            default:
+                LOG_WARNING(Service_Audio, "ADSP AudioRenderer received an invalid message, msg={:02X}!", msg);
+                break;
+            }
+        }
+    });
 
     mailbox.Send(Direction::DSP, Message::InitializeOK);
     if (mailbox.Receive(Direction::Host) != Message::InitializeOK) {
@@ -129,95 +217,4 @@ void AudioRenderer::CreateSinkStreams() {
     }
 }
 
-void AudioRenderer::Main(std::stop_token stop_token) {
-    Common::SetCurrentThreadName("DSP_AudioRenderer_Main");
-    Common::SetCurrentThreadPriority(Common::ThreadPriority::High);
-
-    // TODO: Create buffer map/unmap thread + mailbox
-    // TODO: Create gMix devices, initialize them here
-
-    if (mailbox.Receive(Direction::DSP) != Message::InitializeOK) {
-        LOG_ERROR(Service_Audio, "ADSP Audio Renderer -- Failed to receive initialize message from host!");
-        return;
-    }
-
-    mailbox.Send(Direction::Host, Message::InitializeOK);
-
-    // 0.12 seconds (2,304,000 / 19,200,000)
-    constexpr u64 max_process_time{2'304'000ULL};
-
-    while (!stop_token.stop_requested()) {
-        auto msg{mailbox.Receive(Direction::DSP)};
-        switch (msg) {
-        case Message::Shutdown:
-            mailbox.Send(Direction::Host, Message::Shutdown);
-            return;
-
-        case Message::Render: {
-            if (system.IsShuttingDown()) {
-                std::this_thread::sleep_for(std::chrono::milliseconds(200));
-                mailbox.Send(Direction::Host, Message::RenderResponse);
-                continue;
-            }
-            std::array<bool, MaxRendererSessions> buffers_reset{};
-            std::array<u64, MaxRendererSessions> render_times_taken{};
-            const auto start_time{system.CoreTiming().GetGlobalTimeUs().count()};
-
-            for (u32 index = 0; index < MaxRendererSessions; index++) {
-                auto& command_buffer{command_buffers[index]};
-                auto& command_list_processor{command_list_processors[index]};
-
-                // Check this buffer is valid, as it may not be used.
-                if (command_buffer.buffer != 0) {
-                    // If there are no remaining commands (from the previous list),
-                    // this is a new command list, initialize it.
-                    if (command_buffer.remaining_command_count == 0) {
-                        command_list_processor.Initialize(system, *command_buffer.process,
-                            command_buffer.buffer,
-                            command_buffer.size, streams[index]);
-                    }
-
-                    if (command_buffer.reset_buffer && !buffers_reset[index]) {
-                        streams[index]->ClearQueue();
-                        buffers_reset[index] = true;
-                    }
-
-                    u64 max_time{max_process_time};
-                    if (index == 1 && command_buffer.applet_resource_user_id ==
-                                          command_buffers[0].applet_resource_user_id) {
-                        max_time = max_process_time - render_times_taken[0];
-                        if (render_times_taken[0] > max_process_time) {
-                            max_time = 0;
-                        }
-                    }
-
-                    max_time = (std::min)(command_buffer.time_limit, max_time);
-                    command_list_processor.SetProcessTimeMax(max_time);
-
-                    if (index == 0) {
-                        streams[index]->WaitFreeSpace(stop_token);
-                    }
-
-                    // Process the command list
-                    {
-                        render_times_taken[index] =
-                            command_list_processor.Process(index) - start_time;
-                    }
-
-                    const auto end_time{system.CoreTiming().GetGlobalTimeUs().count()};
-
-                    command_buffer.remaining_command_count =
-                        command_list_processor.GetRemainingCommandCount();
-                    command_buffer.render_time_taken_us = end_time - start_time;
-                }
-            }
-            mailbox.Send(Direction::Host, Message::RenderResponse);
-        } break;
-        default:
-            LOG_WARNING(Service_Audio, "ADSP AudioRenderer received an invalid message, msg={:02X}!", msg);
-            break;
-        }
-    }
-}
-
 } // namespace AudioCore::ADSP::AudioRenderer

src/audio_core/adsp/apps/audio_renderer/audio_renderer.h

@@ -1,4 +1,4 @@
-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project
+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project
 // SPDX-License-Identifier: GPL-3.0-or-later
 
 // SPDX-FileCopyrightText: Copyright 2023 yuzu Emulator Project
@@ -82,11 +82,6 @@ public:
     u64 GetRenderingStartTick(s32 session_id) const noexcept;
 
 private:
-    /**
-     * Main AudioRenderer thread, responsible for processing the command lists.
-     */
-    void Main(std::stop_token stop_token);
-
     /**
      * Creates the streams which will receive the processed samples.
      */

src/audio_core/adsp/apps/opus/opus_decoder.cpp

@@ -37,7 +37,9 @@ bool IsValidMultiStreamStreamCounts(s32 total_stream_count, s32 stereo_stream_co
 } // namespace
 
 OpusDecoder::OpusDecoder(Core::System& system_) : system{system_} {
-    init_thread = std::jthread([this](std::stop_token stop_token) { Init(stop_token); });
+    init_thread = std::jthread([this](std::stop_token stop_token) {
+        Init(stop_token);
+    });
 }
 
 OpusDecoder::~OpusDecoder() {
@@ -64,22 +66,16 @@ u32 OpusDecoder::Receive(Direction dir, std::stop_token stop_token) {
     return mailbox.Receive(dir, stop_token);
 }
 
-void OpusDecoder::Init(std::stop_token stop_token) {
+void OpusDecoder::Init(std::stop_token rc_stop_token) {
     Common::SetCurrentThreadName("DSP_OpusDecoder_Init");
 
-    if (Receive(Direction::DSP, stop_token) != Message::Start) {
-        LOG_ERROR(Service_Audio,
-                  "DSP OpusDecoder failed to receive Start message. Opus initialization failed.");
+    if (Receive(Direction::DSP, rc_stop_token) != Message::Start) {
+        LOG_ERROR(Service_Audio, "DSP OpusDecoder failed to receive Start message. Opus initialization failed.");
         return;
     }
-    main_thread = std::jthread([this](std::stop_token st) { Main(st); });
-    running = true;
-    Send(Direction::Host, Message::StartOK);
-}
-
-void OpusDecoder::Main(std::stop_token stop_token) {
+    // Main OpusDecoder thread, responsible for processing the incoming Opus packets.
+    main_thread = std::jthread([this](std::stop_token stop_token) {
         Common::SetCurrentThreadName("DSP_OpusDecoder_Main");
-
         while (!stop_token.stop_requested()) {
             auto msg = Receive(Direction::DSP, stop_token);
             switch (msg) {
@@ -264,6 +260,9 @@ void OpusDecoder::Main(std::stop_token stop_token) {
                 continue;
             }
         }
+    });
+    running = true;
+    Send(Direction::Host, Message::StartOK);
 }
 
 } // namespace AudioCore::ADSP::OpusDecoder

src/audio_core/adsp/apps/opus/opus_decoder.h

@@ -1,3 +1,6 @@
+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project
+// SPDX-License-Identifier: GPL-3.0-or-later
+
 // SPDX-FileCopyrightText: Copyright 2023 yuzu Emulator Project
 // SPDX-License-Identifier: GPL-2.0-or-later
 
@@ -69,10 +72,6 @@ private:
      * Initializing thread, launched at audio_core boot to avoid blocking the main emu boot thread.
      */
     void Init(std::stop_token stop_token);
-    /**
-     * Main OpusDecoder thread, responsible for processing the incoming Opus packets.
-     */
-    void Main(std::stop_token stop_token);
 
     /// Core system
     Core::System& system;

src/core/hle/service/nifm/nifm.cpp

@@ -277,7 +277,17 @@ private:
         state.store(State::Processing);
         evt_processing->Signal();
 
-        worker = std::thread(&IScanRequest::WorkerThread, this);
+        worker = std::thread([this]() {
+            using namespace std::chrono_literals;
+            scan_results = Network::ScanWifiNetworks(3s);
+            {
+                std::scoped_lock lk{g_scan_mtx};
+                g_last_scan_results = scan_results;
+            }
+            // choose result code
+            const bool ok = !scan_results.empty();
+            Finish(ok ? ResultSuccess : ResultPendingConnection);
+        });
         IPC::ResponseBuilder{ctx, 2}.Push(ResultSuccess);
     }
 
@@ -308,21 +318,6 @@ private:
 
     enum class State { Idle, Processing, Finished };
 
-    void WorkerThread() {
-        using namespace std::chrono_literals;
-
-        scan_results = Network::ScanWifiNetworks(3s);
-
-        {
-            std::scoped_lock lk{g_scan_mtx};
-            g_last_scan_results = scan_results;
-        }
-
-        // choose result code
-        const bool ok = !scan_results.empty();
-        Finish(ok ? ResultSuccess : ResultPendingConnection);
-    }
-
     void Finish(Result rc) {
         worker_result.store(rc);
         state.store(State::Finished);

src/video_core/renderer_vulkan/vk_scheduler.cpp

@@ -59,7 +59,57 @@ Scheduler::Scheduler(const Device& device_, StateTracker& state_tracker_)
 
     AcquireNewChunk();
     AllocateWorkerCommandBuffer();
-    worker_thread = std::jthread([this](std::stop_token token) { WorkerThread(token); });
+    worker_thread = std::jthread([this](std::stop_token stop_token) {
+        Common::SetCurrentThreadName("VulkanWorker");
+        const auto TryPopQueue{[this](auto& work) -> bool {
+            if (work_queue.empty()) {
+                return false;
+            }
+
+            work = std::move(work_queue.front());
+            work_queue.pop();
+            event_cv.notify_all();
+            return true;
+        }};
+
+        while (!stop_token.stop_requested()) {
+            std::unique_ptr<CommandChunk> work;
+
+            {
+                std::unique_lock lk{queue_mutex};
+
+                // Wait for work.
+                event_cv.wait(lk, stop_token, [&] { return TryPopQueue(work); });
+
+                // If we've been asked to stop, we're done.
+                if (stop_token.stop_requested()) {
+                    return;
+                }
+
+                // Exchange lock ownership so that we take the execution lock before
+                // the queue lock goes out of scope. This allows us to force execution
+                // to complete in the next step.
+                std::exchange(lk, std::unique_lock{execution_mutex});
+
+                // Perform the work, tracking whether the chunk was a submission
+                // before executing.
+                const bool has_submit = work->HasSubmit();
+                work->ExecuteAll(current_cmdbuf, current_upload_cmdbuf);
+
+                // If the chunk was a submission, reallocate the command buffer.
+                if (has_submit) {
+                    AllocateWorkerCommandBuffer();
+                }
+            }
+
+            {
+                std::scoped_lock rl{reserve_mutex};
+
+                // Recycle the chunk back to the reserve.
+                chunk_reserve.emplace_back(std::move(work));
+            }
+        }
+    });
 }
 
 Scheduler::~Scheduler() = default;
@@ -187,59 +237,6 @@ bool Scheduler::UpdateRescaling(bool is_rescaling) {
     return true;
 }
 
-void Scheduler::WorkerThread(std::stop_token stop_token) {
-    Common::SetCurrentThreadName("VulkanWorker");
-
-    const auto TryPopQueue{[this](auto& work) -> bool {
-        if (work_queue.empty()) {
-            return false;
-        }
-
-        work = std::move(work_queue.front());
-        work_queue.pop();
-        event_cv.notify_all();
-        return true;
-    }};
-
-    while (!stop_token.stop_requested()) {
-        std::unique_ptr<CommandChunk> work;
-
-        {
-            std::unique_lock lk{queue_mutex};
-
-            // Wait for work.
-            event_cv.wait(lk, stop_token, [&] { return TryPopQueue(work); });
-
-            // If we've been asked to stop, we're done.
-            if (stop_token.stop_requested()) {
-                return;
-            }
-
-            // Exchange lock ownership so that we take the execution lock before
-            // the queue lock goes out of scope. This allows us to force execution
-            // to complete in the next step.
-            std::exchange(lk, std::unique_lock{execution_mutex});
-
-            // Perform the work, tracking whether the chunk was a submission
-            // before executing.
-            const bool has_submit = work->HasSubmit();
-            work->ExecuteAll(current_cmdbuf, current_upload_cmdbuf);
-
-            // If the chunk was a submission, reallocate the command buffer.
-            if (has_submit) {
-                AllocateWorkerCommandBuffer();
-            }
-        }
-
-        {
-            std::scoped_lock rl{reserve_mutex};
-
-            // Recycle the chunk back to the reserve.
-            chunk_reserve.emplace_back(std::move(work));
-        }
-    }
-}
-
 void Scheduler::AllocateWorkerCommandBuffer() {
     current_cmdbuf = vk::CommandBuffer(command_pool->Commit(), device.GetDispatchLoader());
     current_cmdbuf.Begin({

src/video_core/renderer_vulkan/vk_scheduler.h

@@ -251,8 +251,6 @@ private:
         bool needs_state_enable_refresh = false;
     };
 
-    void WorkerThread(std::stop_token stop_token);
-
     void AllocateWorkerCommandBuffer();
 
     u64 SubmitExecution(VkSemaphore signal_semaphore, VkSemaphore wait_semaphore);