diff --git a/src/common/host_memory.cpp b/src/common/host_memory.cpp index b8fbc3dd8e..5f600fa2f7 100644 --- a/src/common/host_memory.cpp +++ b/src/common/host_memory.cpp @@ -731,9 +731,8 @@ void HostMemory::Map(size_t virtual_offset, size_t host_offset, size_t length, M ASSERT(length % PageAlignment == 0); ASSERT(virtual_offset + length <= virtual_size); ASSERT(host_offset + length <= backing_size); - if (length == 0 || !virtual_base || !impl) { + if (length == 0 || !virtual_base || !impl) return; - } impl->Map(virtual_offset + virtual_base_offset, host_offset, length, perms); #endif } @@ -743,9 +742,8 @@ void HostMemory::Unmap(size_t virtual_offset, size_t length, bool separate_heap) ASSERT(virtual_offset % PageAlignment == 0); ASSERT(length % PageAlignment == 0); ASSERT(virtual_offset + length <= virtual_size); - if (length == 0 || !virtual_base || !impl) { + if (length == 0 || !virtual_base || !impl) return; - } impl->Unmap(virtual_offset + virtual_base_offset, length); #endif } @@ -766,7 +764,8 @@ void HostMemory::Protect(size_t virtual_offset, size_t length, MemoryPermission } void HostMemory::ClearBackingRegion(size_t physical_offset, size_t length, u32 fill_value) { - std::memset(backing_base + physical_offset, fill_value, length); + if (!impl) + std::memset(backing_base + physical_offset, fill_value, length); } void HostMemory::EnableDirectMappedAddress() { diff --git a/src/common/virtual_buffer.h b/src/common/virtual_buffer.h index af51949a10..adfdbb75d4 100644 --- a/src/common/virtual_buffer.h +++ b/src/common/virtual_buffer.h @@ -39,7 +39,8 @@ public: VirtualBuffer& operator=(const VirtualBuffer&) = delete; VirtualBuffer(VirtualBuffer&& other) noexcept - : alloc_size{std::exchange(other.alloc_size, 0)}, base_ptr{std::exchange(other.base_ptr), nullptr} + : alloc_size{std::exchange(other.alloc_size, 0)} + , base_ptr{std::exchange(other.base_ptr, nullptr)} {} VirtualBuffer& operator=(VirtualBuffer&& other) noexcept {